-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2rayu 4.2.1 #178825
v2rayu 4.2.1 #178825
Conversation
7f27975
to
6f6e71a
Compare
Again, updating from a prerelease to another prerelease. 4.2.2 is the same build but with no signature so do not update. |
I'm not exactly sure what's going on with this cask. The hashes are the same for each architecture. We should downgrade this to whatever is the latest stable signed release. If they are not planning to sign releases in the future, this should be deprecated instead. cc @Homebrew/cask for additional thoughts. |
They seem to be releasing two versions for each build, one signed and one not signed. I’m definitely against downgrading though, the new config file is incompatible with the old version and will break everyone’s installation. |
Agreed that we should not downgrade if it will break things for users. We should probably open an upstream issue asking for clarification on their release process so we can handle this correctly moving forward. I'd like to understand the use of pre-releases, the signed/unsigned situation, and why/how both architectures have the exact same hash. @i0ntempest Do you happen to speak Mandarin? If so, would you be comfortable opening an issue? If not, I can open one but it would be in English. |
I do. I’ll ask for some clarification once I get time. |
Opened a discussion to ask for clarification. |
Thank you so much @i0ntempest 🙏 |
Two weeks without any response. Opened an issue instead. |
We got a response. Upstream dev said:
I've told him that removing the certificate will result in the cask being deprecated/removed (I believe we added this audit for cask upgrades not long ago). Let's see what he says about that. |
Thanks for the follow up. Let's wait for 4.2 to be released this week, and then we can update and merge this. |
v4.2.5 is now live and marked as the latest release. I've opened #180909 to bump to that version and add a livecheck to not return pre-release versions anymore. |
Created with
brew bump-cask-pr
.